yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor 
failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r276196291
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
 ##########
 @@ -101,7 +100,7 @@
        private final CheckpointStorageLocation targetLocation;
 
        /** The promise to fulfill once the checkpoint has been completed. */
-       private final CompletableFuture<CompletedCheckpoint> 
onCompletionPromise;
+       private final CompletableFuture<CheckpointExecutionResult> 
onCompletionPromise;
 
 Review comment:
   So next, I think I should adjust my design document based on our discussion. 
Then, I would invite you to review it again and discuss based on the new 
document. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to