yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor
failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r275145014
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -405,54 +404,22 @@ public void addMasterState(MasterState state) {
//
------------------------------------------------------------------------
/**
- * Aborts a checkpoint because it expired (took too long).
+ * Aborts a checkpoint with abort reason and cause.
*/
- public void abortExpired() {
+ public void abort(CheckpointAbortReason reason, Throwable cause) {
try {
- Exception cause = new Exception("Checkpoint expired
before completing");
- onCompletionPromise.completeExceptionally(cause);
- reportFailedCheckpoint(cause);
+ onCompletionPromise.complete(new
CheckpointExecuteResult(reason, cause));
Review comment:
@StefanRRichter The `CheckpointExecuteResult` used to represent the
execution result of Checkpoint just like `CheckpointTriggerResult` which means
trigger result of Checkpoint. They would be both used in `CheckpointFailure` to
counter the failure number(further work, step two, see :
https://docs.google.com/document/d/1ce7RtecuTxcVUJlnU44hzcO2Dwq9g4Oyd8_biy94hJc/edit?usp=sharing).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
