Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135768996
Wow that is some really big piece of work @mjsax. Thanks for your
contribution. To be honest, I actually thought you would only adapt your newly
written test. As far as I can tell, your changes look good. There is only small
addition which would be great to have. That is to let the changed test cases
extend the `TestLogger` class. That way, we'll get proper log file output on
Travis.
Other than that, we only have to resolve the question about an explicit
`StoppingFailure` message or throwing an `Exception` instead. I don't have a
strong preference for any solution and just wanted to get a discussion about it
started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
