Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38194969
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
    @@ -411,6 +411,23 @@ class TaskManager(
                 log.debug(s"Cannot find task to fail for execution 
${executionID})")
               }
     
    +        // stops a task
    +        case StopTask(executionID) =>
    +          val task = runningTasks.get(executionID)
    +          if (task != null) {
    +            try {
    +              task.stopExecution()
    +              sender ! new TaskOperationResult(executionID, true)
    +            } catch {
    +              case t: Throwable =>
    +                        sender ! new TaskOperationResult(executionID, 
false, t.getMessage())
    --- End diff --
    
    If only an `UnsupportedOperationException` can be thrown, then it is fine. 
To be honest, I don't know why the `TaskOperationResult` stores the exception 
as a string. I assume that it's some legacy artifact. I'm not a big fan of it. 
But you can use the `StringUtils.stringifyException` to also include the stack 
trace of the exception in the string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to