Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38192065
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/RemoteExecutorHostnameResolutionTest.java
---
@@ -88,15 +65,14 @@ private static void checkPreconditions() {
// the test can only work if the invalid URL cannot be resolves
// some internet providers resolve unresolvable URLs to
navigational aid servers,
// voiding this test.
- boolean throwsException;
try {
//noinspection ResultOfMethodCallIgnored
InetAddress.getByName(nonExistingHostname);
- throwsException = false;
}
catch (UnknownHostException e) {
- throwsException = true;
+ return;
}
- assumeTrue(throwsException);
+
+ fail("Expected UnknownHostException but none was thrown.");
--- End diff --
Matter of taste. I change it. I don't care.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
