Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38195523
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
log.debug(s"Cannot find task to fail for execution
${executionID})")
}
+ // stops a task
+ case StopTask(executionID) =>
+ val task = runningTasks.get(executionID)
+ if (task != null) {
+ try {
+ task.stopExecution()
+ sender ! new TaskOperationResult(executionID, true)
+ } catch {
+ case t: Throwable =>
+ sender ! new TaskOperationResult(executionID,
false, t.getMessage())
--- End diff --
Hmmm... `task.stopExecution()` has the call to `userfunction.cancel()`
nested inside. If there is an exception there it can hit us here... So catching
`Throwable` an send back the result using `StringUtils.stringifyException`
might just be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
