[
https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653153#comment-16653153
]
ASF GitHub Bot commented on FLINK-10527:
----------------------------------------
TisonKun commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode in
YarnTestBase
URL: https://github.com/apache/flink/pull/6816#issuecomment-430528080
@yanghua changes LGTM and for your statement on "block FLINK-10292", it
should have not been.
Document on Junit announces:
```java
/**
* If called with an expression evaluating to {@code false}, the test
will halt and be ignored.
*
* @param b If <code>false</code>, the method will attempt to stop the
test and ignore it by
* throwing {@link AssumptionViolatedException}.
* @param message A message to pass to {@link
AssumptionViolatedException}.
*/
public static void assumeTrue(String message, boolean b) {
if (!b) throw new AssumptionViolatedException(message);
}
```
So the error message occurs on
https://api.travis-ci.org/v3/job/439612829/log.txt can be ignored. Also I'd
like to get input from @zentol to see if the test env has some trouble.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cleanup constant isNewMode in YarnTestBase
> ------------------------------------------
>
> Key: FLINK-10527
> URL: https://issues.apache.org/jira/browse/FLINK-10527
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> This seems to be a residual problem with FLINK-10396. It is set to true in
> that PR. Currently it has three usage scenarios:
> 1. assert, caused an error
> {code:java}
> assumeTrue("The new mode does not start TMs upfront.", !isNewMode);
> {code}
> 2. if (!isNewMode) the logic in the block would not have invoked, the if
> block can be removed
> 3. if (isNewMode) always been invoked, the if statement can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
