[
https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649950#comment-16649950
]
ASF GitHub Bot commented on FLINK-10527:
----------------------------------------
yanghua commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode in
YarnTestBase
URL: https://github.com/apache/flink/pull/6816#issuecomment-429769018
> Hi @yanghua , I see your last commit and think it is still use the legacy
mode. (Since you start an actor system and use `ActorGateway` instead of using
FLIP-6 components.)
@TisonKun From my last comment, I am currently focusing on the failure of
YARNSessionCapacitySchedulerITCase#testTaskManagerFailure.
> To minimize this pull request as its title "Cleanup constant isNewMode in
YarnTestBase", I propose to retain the clean up in `YARNSessionFIFOITCase`,
simply remove `isNewMode` and add `@Ignore` to `YARNHighAvailabilityITCase`,
`YARNSessionCapacitySchedulerITCase#testClientStartup` and
`YARNSessionCapacitySchedulerITCase#testTaskManagerFailure`. Meanwhile, raising
a JIRA about port those tests. What do you think?
Agree your opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cleanup constant isNewMode in YarnTestBase
> ------------------------------------------
>
> Key: FLINK-10527
> URL: https://issues.apache.org/jira/browse/FLINK-10527
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> This seems to be a residual problem with FLINK-10396. It is set to true in
> that PR. Currently it has three usage scenarios:
> 1. assert, caused an error
> {code:java}
> assumeTrue("The new mode does not start TMs upfront.", !isNewMode);
> {code}
> 2. if (!isNewMode) the logic in the block would not have invoked, the if
> block can be removed
> 3. if (isNewMode) always been invoked, the if statement can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
