[
https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649943#comment-16649943
]
ASF GitHub Bot commented on FLINK-10527:
----------------------------------------
tillrohrmann commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode
in YarnTestBase
URL: https://github.com/apache/flink/pull/6816#issuecomment-429767716
I agree with @TisonKun to do the porting step by step. I would even say to
remove the `isNewMode` last after all the porting has been done.
Concerning `YARNSessionCapacitySchedulerITCase#testTaskManagerFailure`, I
think you're right @yanghua and we have to submit a blocking job to test the
behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cleanup constant isNewMode in YarnTestBase
> ------------------------------------------
>
> Key: FLINK-10527
> URL: https://issues.apache.org/jira/browse/FLINK-10527
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> This seems to be a residual problem with FLINK-10396. It is set to true in
> that PR. Currently it has three usage scenarios:
> 1. assert, caused an error
> {code:java}
> assumeTrue("The new mode does not start TMs upfront.", !isNewMode);
> {code}
> 2. if (!isNewMode) the logic in the block would not have invoked, the if
> block can be removed
> 3. if (isNewMode) always been invoked, the if statement can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
