[
https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655636#comment-16655636
]
ASF GitHub Bot commented on FLINK-10527:
----------------------------------------
tillrohrmann commented on a change in pull request #6816: [FLINK-10527] Cleanup
constant isNewMode in YarnTestBase
URL: https://github.com/apache/flink/pull/6816#discussion_r226396417
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java
##########
@@ -189,9 +189,9 @@ public void perJobYarnClusterOffHeap() throws IOException {
/**
* Test TaskManager failure and also if the vcores are set correctly
(see issue FLINK-2213).
*/
+ @Ignore
@Test(timeout = 100000) // timeout after 100 seconds
public void testTaskManagerFailure() throws Exception {
- assumeTrue("The new mode does not start TMs upfront.",
!isNewMode);
Review comment:
I think the problem is that there was another precondition violated which
caused a `MultipleFailureException` to be thrown and due to that the
`AssumptionException` was not properly treated as ignoring the respective test
case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cleanup constant isNewMode in YarnTestBase
> ------------------------------------------
>
> Key: FLINK-10527
> URL: https://issues.apache.org/jira/browse/FLINK-10527
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> This seems to be a residual problem with FLINK-10396. It is set to true in
> that PR. Currently it has three usage scenarios:
> 1. assert, caused an error
> {code:java}
> assumeTrue("The new mode does not start TMs upfront.", !isNewMode);
> {code}
> 2. if (!isNewMode) the logic in the block would not have invoked, the if
> block can be removed
> 3. if (isNewMode) always been invoked, the if statement can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
