Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4373#discussion_r130827249
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/JoinTest.scala
 ---
    @@ -55,12 +55,13 @@ class JoinTest extends TableTestBase {
               unaryNode(
                 "DataStreamCalc",
                 streamTableNode(1),
    -            term("select", "a", "b", "proctime")
    +            term("select", "a", "b", "-(proctime, 3600000) AS -",
    --- End diff --
    
    Yes, I'm also curious why this plan would be generated. AFAIK, the 
`DataStreamWindowJoin` is very strict about the join predicates it accepts. It 
needs two range predicates with time indicator attributes on both sides. If the 
computation is pushed into the `DataStreamCalc` the time indicator attribute 
should be materialized and no longer be identified as a time indicator. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to