Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4373#discussion_r129240196
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/CorrelateTest.scala
 ---
    @@ -43,7 +43,7 @@ class CorrelateTest extends TableTestBase {
             term("invocation", "func1($cor0.c)"),
             term("function", func1.getClass.getCanonicalName),
             term("rowType",
    -             "RecordType(INTEGER a, BIGINT b, VARCHAR(2147483647) c, 
VARCHAR(2147483647) f0)"),
    +             "RecordType(INTEGER a, BIGINT b, VARCHAR(65536) c, 
VARCHAR(65536) f0)"),
    --- End diff --
    
    It seems that Calcite has defined an upper limit for strings and ignores 
our size. Can you also update this in `FlinkTypeSystem` and the comment in 
`FlinkTypeFactory#createSqlType`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to