Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4373#discussion_r129237531
  
    --- Diff: 
flink-libraries/flink-table/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
 ---
    @@ -1869,13 +1869,23 @@ private RexNode convertOver(Blackboard bb, SqlNode 
node) {
                        // Walk over the tree and apply 'over' to all agg 
functions. This is
                        // necessary because the returned expression is not 
necessarily a call
                        // to an agg function. For example, AVG(x) becomes 
SUM(x) / COUNT(x).
    +
    --- End diff --
    
    I think we can remove this file for now and rely on Calcite 1.13 
implementation. We don't need it anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to