[ 
https://issues.apache.org/jira/browse/FLINK-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099707#comment-16099707
 ] 

ASF GitHub Bot commented on FLINK-7192:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4335#discussion_r129242316
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/operator/SortPartitionTest.java
 ---
    @@ -251,32 +254,42 @@ public CustomType getKey(Tuple4<Integer, Long, 
CustomType, Long[]> value) throws
                        .sortPartition("f1", Order.ASCENDING);
        }
     
    +   /**
    +    * Custom data type, for testing purposes.
    +    */
        public static class CustomType implements Serializable {
    -           
    +
    +           /**
    +            * Custom nested data type, for testing purposes.
    +            */
                public static class Nest {
                        public int myInt;
                }
    +
                private static final long serialVersionUID = 1L;
    -           
    +
                public int myInt;
                public long myLong;
                public String myString;
                public Nest nested;
    -           
    +
                public CustomType() {}
     
                public CustomType(int i, long l, String s) {
                        myInt = i;
                        myLong = l;
                        myString = s;
                }
    -           
    +
                @Override
                public String toString() {
    -                   return myInt+","+myLong+","+myString;
    +                   return myInt + "," + myLong + "," + myString;
                }
        }
     
    +   /**
    +    * Another custom data type, for testing purposes.
    --- End diff --
    
    I removed this class entirely as it was not used.


> Activate checkstyle flink-java/test/operator
> --------------------------------------------
>
>                 Key: FLINK-7192
>                 URL: https://issues.apache.org/jira/browse/FLINK-7192
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to