Hi Dmitry, On Fri, Jun 10, 2016 at 9:37 PM, Dmitry Stogov <dmi...@zend.com> wrote: > I hardly worked on implementation of this patch for a week, but I still don't > like it. > > It makes 15% slowdown on each property update in existing PHP code (without > types), and I don't see a way to improve this. > > Update of typed properties is going to be even more expensive. > > Benchmark results are included into RFC (and not changed with the latest > version of the patch). > > > -1.
If we are concerned about performance, DbC would be the only solution for this kind of problem. i.e. Validate fully during development, do minimum validation on production. DbC helps type inference also. There may not be enough time for discussion, but do you think there is enough time for implementation? I suppose implementation is straightforward, so it might be OK to have RFC w/o implementation. We have 2 options anyway. It's waste of time for having 2 implementations. Would you like to proceed the RFC for 7.1? Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
