On 06/10/2016 05:24 PM, Levi Morrison wrote:
On Fri, Jun 10, 2016 at 6:37 AM, Dmitry Stogov <dmi...@zend.com><mailto:dmi...@zend.com> wrote: Hi, I hardly worked on implementation of this patch for a week, but I still don't like it. It makes 15% slowdown on each property update in existing PHP code (without types), and I don't see a way to improve this. Update of typed properties is going to be even more expensive. Benchmark results are included into RFC (and not changed with the latest version of the patch). -1. Thanks. Dmitry. ________________________________ From: Joe Watkins <pthre...@pthreads.org><mailto:pthre...@pthreads.org> Sent: Friday, June 10, 2016 1:38:04 PM To: PHP internals; Phil Sturgeon Subject: [PHP-DEV] [RFC][Vote] Typed Properties Afternoon internals, The vote for typed properties has been restarted. Please take part: https://wiki.php.net/rfc/typed-properties Cheers Joe To clarify though, didn't Wordpress and Mediawiki see only a 0.1% slowdown? In my opinion that is definitely a tolerable performance hit for such a feature. I don't see any big value in this feature. Most framework access object properties through getters and setters anyway. They can be and should be used to provide type-safe API. Another level of protection that makes slowdown instead of expected speedup, dosn't make any sense. Thanks. Dmitry.
