Hi Ferenc,
> On 22.07.2014, at 14:38, Ferenc Kovacs <tyr...@gmail.com> wrote: > > On Mon, Jul 14, 2014 at 6:35 PM, Nikita Popov <nikita....@gmail.com> wrote: > >> On Mon, Jul 7, 2014 at 4:18 PM, Nikita Popov <nikita....@gmail.com> wrote: >> >>> Hi internals! >>> >>> I've started the vote on the Uniform Variable Syntax RFC: >>> >>> https://wiki.php.net/rfc/uniform_variable_syntax#vote >>> >>> You can review the discussion about this RFC here: >>> >>> http://markmail.org/message/mr4ihbubfbdxygci >>> >>> The vote requires a 2/3 majority and is planned to end on 2014-07-14. The >>> RFC targets PHP 6. >>> >> >> The vote closed with 30 in favor and 1 against, as such the RFC is >> accepted. >> >> I will delay merging the patch until the situation regarding phpng and PHP >> 6 is more clear. >> >> Thanks, >> Nikita >> > > Hi Nikita, > > Derick mentioned in his blogpost( > http://derickrethans.nl/uniform-variable-syntax.html) that "You can't > really write a scanner for it, as the code could already have been > converted.". > I know that you posted https://gist.github.com/nikic/ffd019ef78b72934c7cc > which uses PhpParser\Lexer from your PHP-Parser project, so my > understanding was that it is possible to detect those expressions with both > the current php stable version and with the new one containing the > uniform_variable_syntax changes. the point Derick was trying to make is that you can’t build a scanner that automatically checks whether you rewrote this particular piece of code already or not. You can find the code pieces which match the constructs affected by the BC, but the scanner can’t decide, whether they are already fixed (= they are ok as they stand). Which makes the burden of the update smaller, but you still need to check every match yourself, whether it will (still) work. (at least I read it like this) Cheers Jannik > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
