+1 with Andi's improvement.

Gustavo - I realize it's not about changing the token's name, but nobody (=very 
few) looks at the token names.  The point is to keep the tradition of also 
exposing this specific token name to the user, but still making it clear that 
what was expected was :: - without the need to head to Google Translate...

Zeev

> -----Original Message-----
> From: Felipe Pena [mailto:felipe...@gmail.com]
> Sent: Tuesday, May 17, 2011 5:18 PM
> To: internals
> Subject: [PHP-DEV] Re: [RFC] Improved parser error message
> 
> 2011/5/16 Felipe Pena <felipe...@gmail.com>
> 
> > Hi all,
> > As I have proposed previously in an old thread... What about we name
> > all the tokens to have an improved parser error message? (i.e. anymore
> > T_PAAMAYIM_NEKUDOTAYIM, T_DOLLAR_OPEN_CURLY_BRACES in the
> messages
> > etc)
> >
> 
> > [...]
> >
> 
> >
> Other examples and patch at:
> > https://wiki.php.net/rfc/improved-parser-error-message
> >
> > Any thoughts?
> >
> > Thanks.
> >
> 
> So... In case of no objections, I'll commit it in trunk and 5_4 branch, Is it 
> okay?
> :)
> 
> --
> Regards,
> Felipe Pena

Reply via email to