Hi Felipe,

Read the archives. We discussed T_PAAMAYIM_NEKUDOTAYIM extensively and agreed 
to keep it as a historical landmark. Let's not have the discussion yet again 
within the same year. Google it just to see the # of mentions. 

What we could do as a compromise between history and improving many of the 
parse error messages is:
Parse error: syntax error, unexpected :: (T_PAAMAYIM_NEKUDOTAYIM) in Command 
line code on line 1

Generally speaking I'm OK with the other changes but I don't know if any 
extensions or scripts depend on them (probably not).
I suggest to give it another couple of days to see if anyone has any valid 
concerns on breakage this could cause.

Andi

>-----Original Message-----
>From: Felipe Pena [mailto:felipe...@gmail.com]
>Sent: Tuesday, May 17, 2011 7:18 AM
>To: internals
>Subject: [PHP-DEV] Re: [RFC] Improved parser error message
>
>2011/5/16 Felipe Pena <felipe...@gmail.com>
>
>> Hi all,
>> As I have proposed previously in an old thread... What about we name
>> all the tokens to have an improved parser error message? (i.e. anymore
>> T_PAAMAYIM_NEKUDOTAYIM, T_DOLLAR_OPEN_CURLY_BRACES in the
>messages
>> etc)
>>
>
>> [...]
>>
>
>>
>Other examples and patch at:
>> https://wiki.php.net/rfc/improved-parser-error-message
>>
>> Any thoughts?
>>
>> Thanks.
>>
>
>So... In case of no objections, I'll commit it in trunk and 5_4 branch, Is it 
>okay? :)
>
>--
>Regards,
>Felipe Pena

Reply via email to