On Tue, May 17, 2011 at 6:01 PM, Andi Gutmans <a...@zend.com> wrote: > Hi Felipe, > > Read the archives. We discussed T_PAAMAYIM_NEKUDOTAYIM extensively and > agreed to keep it as a historical landmark. Let's not have the discussion > yet again within the same year. Google it just to see the # of mentions. > > Maybe you don't remember, but Felipe participated in that discussion, to be exact he proposed this exact feature there: http://www.mail-archive.com/internals@lists.php.net/msg48173.html after Felipe's mail, nobody objected about replacing the constants with meaningful names, as it was the original idea, but nobody found a clean way to implement it before.
> What we could do as a compromise between history and improving many of the > parse error messages is: > Parse error: syntax error, unexpected :: (T_PAAMAYIM_NEKUDOTAYIM) in > Command line code on line 1 > > maybe it's a little bit redundant, but it can be a good transition. > Generally speaking I'm OK with the other changes but I don't know if any > extensions or scripts depend on them (probably not). > I suggest to give it another couple of days to see if anyone has any valid > concerns on breakage this could cause. > > as Felipe mentioned, his patch doesn't modify the token names(so the token_ functions aren't affected by this change), only the rendering of the error messages. Tyrael
