Hi Tristan, Thanks for the nice work :)
Just my 2 cents, in the second patch, since you change the default behavior, you forgot to update your comment from the 1st patch in Lua's doc according to the new behavior: > diff --git a/doc/lua.txt b/doc/lua.txt > index 8d5561668..8d244ab3a 100644 > --- a/doc/lua.txt > +++ b/doc/lua.txt > @@ -630,6 +630,10 @@ It displays a log during the HAProxy startup: > > [alert] 285/083533 (14465) : Hello World ! > > +Note: By default, logs originating from a LUA script are sent to the loggers > +applicable to the current context, if any, and additionally to stderr. See > +tune.lua.log and tune.lua.log-stderr for more information. Note that the lua.txt file is not used much now, and mainly serves as documentation for developers, not very useful for users. If you're willing to reach more people you should probably maintain the doc/lua-api/index.rst file which is used to generate the online documentation at https://www.arpalert.org/haproxy-api.html (related txn:log() documentation: https://www.arpalert.org/src/haproxy-lua-api/2.9/index.html#core.log) For the rest, I'll leave it to Willy :) Regards, Aurelien
