On 20/10/2023 15:30, Tristan wrote:
ie in this snippet (hlua.c:1387):

static inline void hlua_sendlog(struct proxy *px, ...)
{
     ...
     if (... && (!LIST_ISEMPTY(&px->loggers)))
         return;

has the following results:
- locally from source => compiles happily
- locally from clone + patch => compile error
- in CI from clone + patch => compile error

When it fails, this is what I get back:

src/hlua.c:1417:86: error: ‘struct proxy’ has no member named ‘loggers’
 1417 |                         if ((hlua_tune_flags & (HLUA_TUNE_LOG)) && (!LIST_ISEMPTY(&px->loggers)))
       |                      ^~
include/haproxy/list.h:102:28: note: in definition of macro ‘LIST_ISEMPTY’
   102 | #define LIST_ISEMPTY(lh) ((lh)->n == (lh))
       |                            ^~

Which would make sense if struct proxy had no such member, but it most certainly has one...

I must be missing something obvious, which hopefully someone can point out to me...

Well, Aurélien replied off-list and turns out my build scripts were not using the same exact commit I was writing it against... https://github.com/mangadex-pub/haproxy/commit/46c15afd27876c3e260fc0c70234e0aff70422de#r130521133

Thanks Aurélien, and :facepalm: to me

Tristan


Reply via email to