...
One last thing, SEND_ERR() reports to stderr through ha_alert() and
hlua_sendlog() does it through fprintf(stderr, ) by appending a static
header containing the log level, the date and the pid: maybe we should
try to unify those outputs as well?

I'm not sure anyone really *wants* to have to configure all that stuff
for error reporting. Maybe the format is not great, maybe it should use
send_log() etc, quite frankly I don't know as I have not visited that
part. [...]

To be honest here I'm somewhat on Aurélien's side. I would actually appreciate a lua-log-format sort of configurable option.

Mainly so I can prefix (for example) with the timestamp and request id, like I do for HTTP traffic.

Since raw output means it looks a bit odd in logs, and enforcing prefixes inside scripts is a bit of a maintenance burden (and error prone + expensive).

That said, I'd definitely do that in a follow-up patch.

Tristan

Reply via email to