On Tue, Oct 24, 2023 at 11:41:56AM +0000, Tristan wrote: > > On 23/10/2023 14:38, Tristan wrote: > > Thanks both for your time helping me with it :) > > > > On 23/10/2023 14:34, Aurelien DARRAGON wrote: > > > Just a side note regarding the comment from the 2nd patch: it's not > > > useful to mention the commit ID from the previous patch given that the > > > effective commit ID will change when the patch will be applied on top of > > > haproxy master branch. > > > > Oh, I thought patch commit hashes carried through when applied. Well, TIL. > > On that note, I assume the easiest is to let Willy alter the commit message > to update (or remove) the commit reference when merging?
Yeah I just did that. One method we commonly practice with such series is to simply mention 'previous commit "xxx" ...'. It's even more convenient for those reading the logs later because instead of stopping and copy- pasting a commit ID in another window, they know they just need to scroll a little bit more. > Asking just in case you were waiting for me to send an amended patch for it. No don't worry, I'm not for wasting anyone's time respinning patches for a few words I can edit with commit --amend. These are the occasional details we can and do routinely adjust when merging for optimal use of everyone's time (unless the patch is signed). Thanks! Willy
