On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote:
> However I'm well aware that it's easier to work on improvements once the
> script is merged, so what I've done now is to merge it and create a
> temporary "reg-tests2" target in the makefile to use it without losing
> the existing one. This way everyone can work in parallel, and once the
> few issues seem reliably addressed, we can definitely replace the make
> target.
Unfortunately ENOCOFFEE struck me this morning and I forgot to commit
my local changes so I merged the unmodified version which replaces the
"reg-test" target.
Thus now we're condemned to quickly fix these small issues :-)
I've found the problem related to mktemp, it uses "XXXX" as the suffix.
On my distro the man page says :
The mktemp utility takes the given filename template and overwrites a
portion of it to create a unique filename. The template may be any
filename with six (6) `Xs' appended to it, for example
/tmp/tfile.XXXXXX.
I've found that other systems demand at least 3 or at least 1. And the
glibc's mktemp() calll wants 6 anyway or returns EINVAL (the one I got).
Thus we should add 2 more "X" to make this work everywhere mktemp is
present (and test for the output as well).
Willy
