Hi Pieter,

On Tue, Nov 27, 2018 at 11:17:42PM +0100, PiBa-NL wrote:
> I've changed the the script to include the LEVEL parameter almost the way
> the Makefile used it, changed behavior though so without the parameter it it
> runs all tests.
(...)
> New path attached, which includes a LEVEL check.
> And a modification of the Makefile to call the ./scripts/run-regtests.sh

Thank you.

> Please can someone check it again before merging.?. Thanks guys :).

I've run a quick check and am mostly OK with it, though I'll wait for
Fred to re-check this morning before applying it.

I'll just perform a very minor modification below :

> diff --git a/Makefile b/Makefile
(...)
> +     ./scripts/run-regtests.sh --LEVEL "$$LEVEL" $$REG_TEST_FILES

I'll reuse $(REG_TEST_FILES) instead of $$REG_TEST_FILES. The
difference is that the former is resolved by make and will take care
of makefile variables, while the latter is resolved by the shell and
will only see exported environment variables. This is fairly minor,
no need to respin a patch for this ;-)

Thanks,
Willy

Reply via email to