Hi guys, On Tue, Nov 27, 2018 at 09:45:25AM +0100, Frederic Lecaille wrote: > > I put the script in the /reg-tests/ folder. Maybe it should have been > > besides the Makefile in the / root ? > > Yes I think it should be placed at the same level as the Makefile.
Well, we already have a "scripts" directory with the stuff used for release and backport management. I think it perfectly has its place there. > I am sorry Pieter a remaining detail I should have mentioned before: > > + for i in $(find $TESTDIR/ -type d -name "vtc.*"); > + do > + echo "###### $(cat $i/INFO) ######" > + echo "## test results in: $i" > + grep -- ---- $i/LOG > + > + echo "###### $(cat $i/INFO) ######" >> $TESTDIR/failedtests.log > + echo "## test results in: $i" >> $TESTDIR/failedtests.log > + grep -- ---- $i/LOG >> $TESTDIR/failedtests.log > + echo >> $TESTDIR/failedtests.log > + done > > may be shortened thanks to tee command like that: > > cat <<- EOF | tee $TESDIR/failedtests.log > . > . > EOF > > I have tested you script. For me it is OK. Good job! > Thank you a lot Pieter. OK just let me know what to do with this, should I merge it as-is and expect minor updates later, or do you or Pieter want to resend an updated version ? I can adapt, let me know. thanks! Willy
