On 11/25/18 4:59 PM, PiBa-NL wrote:
Hi Frederic, Willy,

Hi Pieter,

Added the varnishtest script we have been discussing as a .patch this time.

I put the script in the /reg-tests/ folder. Maybe it should have been besides the Makefile in the / root ?

Yes I think it should be placed at the same level as the Makefile.

Note that the reg tests must be run from the Makefile with "reg-tests" target and possibly other arguments/variables.

Willy recently added REG_TEST_FILES variable.

Also i put a bit of comments into the commit.

I hope it is okay like this? If not, feel free to comment on them or change them as required.

I am sorry Pieter a remaining detail I should have mentioned before:

+  for i in $(find $TESTDIR/ -type d -name "vtc.*");
+  do
+    echo "###### $(cat $i/INFO) ######"
+    echo "## test results in: $i"
+    grep -- ---- $i/LOG
+
+    echo "###### $(cat $i/INFO) ######" >> $TESTDIR/failedtests.log
+    echo "## test results in: $i" >> $TESTDIR/failedtests.log
+    grep -- ---- $i/LOG >> $TESTDIR/failedtests.log
+    echo >> $TESTDIR/failedtests.log
+  done

may be shortened thanks to tee command like that:

    cat <<- EOF | tee $TESDIR/failedtests.log
    .
    .
    EOF

I have tested you script. For me it is OK. Good job!
Thank you a lot Pieter.

Once this one is 'accepted' ill create a few patches for the existing .vtc files to include their requirements. (at least the more obvious ones..)

Regards,
PiBa-NL (Pieter)



Reply via email to