rishi commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you 
are following:
``
Speaking as someone who maintains a code base where `go build` is invoked by 
Meson ...

> I traced through the commit history and found the commit[1]
> where the %gobuildflags macro was created. It looks like it
> might have been simply an oversight to not update the
> %gobuild macro to use the new %gobuildflags macro.

Maybe something has changed since then, and my memory is a bit foggy because 
it's been a while since my deep dive into the Go toolchain and the RPM macros, 
but it was definitely not an oversight to have `%gobuildflags` duplicate 
`%gobuild`.  The 
[commit](https://pagure.io/go-rpm-macros/c/67b4fbbbfce0986ac46cd1329bf85a18ea7a43d2)
 says:
```
    Ideally the %gobuild macro would in turn reference the
    %gobuildflags macro, but that does not appear possible
    given the semantics around quote expansion and escaping
    across RPM and shell.
```
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/34
_______________________________________________
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to