qulogic commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that 
you are following:
``
I'm actually confused why `%gobuildflags` exists, because `%gobuild`  below 
that doesn't use it. In fact, `%gobuild` uses an exact copy of `gobuildflags` 
with `BUILDTAGS` _already_ there.

I guess `gobuildflags` is there if you need to somehow call `go build` 
manually? But in that case adding `BUILDTAGS` to `gobuildflags` is only halfway 
to making things consistent. `gobuild` should also be changed to _use_ 
`gobuildflags`, or things will fall out of sync again.
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/34
_______________________________________________
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to