rishi commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` > I'm actually confused why %gobuildflags exists, because > %gobuild below that doesn't use it. In fact, %gobuild > uses an exact copy of gobuildflags with BUILDTAGS > already there.
A bit of Git forensics [reveals](https://pagure.io/go-rpm-macros/c/67b4fbbbfce0986ac46cd1329bf85a18ea7a43d2): ``` commit 67b4fbbbfce0986ac46cd1329bf85a18ea7a43d2 Author: Daniel P. Berrangé <berra...@redhat.com> AuthorDate: Wed Sep 18 16:49:58 2019 +0100 Commit: Daniel P. Berrangé <berra...@redhat.com> CommitDate: Thu Sep 19 11:36:33 2019 +0100 macros: define a %gobuildflags macro Using the %gobuild macro is fine for a project where the go code is the only thing being built, and can be built directly by invoking the Go toolchain from RPM. In more complex cases though, the Go code is just a small part of the project and the Go toolchain is invoked by a build system such as make (possibly automake), or meson. In such a case we need to be able to tell this build system what flags to pass to the compiler. The %gobuildflags macros services this purpose allowing a RPM spec todo GOBUILDFLAGS="%gobuildflags" %configure or %make GOBUILDFLAGS="%gobuildflags" Ideally the %gobuild macro would in turn reference the %gobuildflags macro, but that does not appear possible given the semantics around quote expansion and escaping across RPM and shell. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> ``` `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/34 _______________________________________________ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
