linkdupont commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` +1 to `GOBUILDTAGS`. The macros already make use of `GOBUILDFLAGS`, so this follows convention. It also avoids the (albeit narrow) situation where `BUILDTAGS` is already assumed to mean "C build tags" and a spec file is attempting to modify both CGo build configurations and Go build configurations. It's trivial to adjust existing spec files to use `GOBUILDTAGS` instead of `BUILDTAGS`. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/34 _______________________________________________ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
