coderfender commented on code in PR #3269:
URL: https://github.com/apache/datafusion-comet/pull/3269#discussion_r2730617394
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometStringExpressionBenchmark.scala:
##########
@@ -76,7 +76,8 @@ object CometStringExpressionBenchmark extends
CometBenchmarkBase {
StringExprConfig("substring", "select substring(c1, 1, 100) from
parquetV1Table"),
StringExprConfig("translate", "select translate(c1, '123456', 'aBcDeF')
from parquetV1Table"),
StringExprConfig("trim", "select trim(c1) from parquetV1Table"),
- StringExprConfig("upper", "select upper(c1) from parquetV1Table"))
+ StringExprConfig("upper", "select upper(c1) from parquetV1Table"),
+ StringExprConfig("elt", "select elt(2, c1, c1) from parquetV1Table"))
Review Comment:
thank you for adding this in the benchmark setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
