coderfender commented on code in PR #3269:
URL: https://github.com/apache/datafusion-comet/pull/3269#discussion_r2743854183
##########
spark/src/test/scala/org/apache/comet/CometStringExpressionSuite.scala:
##########
@@ -23,13 +23,17 @@ import scala.util.Random
import org.apache.parquet.hadoop.ParquetOutputFormat
import org.apache.spark.sql.{CometTestBase, DataFrame}
+import org.apache.spark.sql.functions.lit
import org.apache.spark.sql.internal.SQLConf
-import org.apache.spark.sql.types.{DataTypes, StructField, StructType}
+import org.apache.spark.sql.types.{DataTypes, StringType, StructField,
StructType}
import org.apache.comet.testing.{DataGenOptions, FuzzDataGenerator}
class CometStringExpressionSuite extends CometTestBase {
+ private val WRONG_NUM_ARGS_WITHOUT_SUGGESTION_EXCEPTION_MSG =
+ "[WRONG_NUM_ARGS.WITHOUT_SUGGESTION] The `elt` requires > 1 parameters but
the actual number is 1."
+
Review Comment:
minor : given that this message is only applicable for your expression test
, may be we could move it inside the test itself ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
