coderfender commented on code in PR #3269:
URL: https://github.com/apache/datafusion-comet/pull/3269#discussion_r2730610554
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -289,6 +289,16 @@ object CometRegExpReplace extends
CometExpressionSerde[RegExpReplace] {
}
}
+object CometElt extends CometScalarFunction[Elt]("elt") {
+
+ override def getSupportLevel(expr: Elt): SupportLevel = {
+ if (expr.failOnError) {
Review Comment:
Thank you for the PR @kazantsev-maksim .Minor nitpick : We generally add
`ANSI mode not supported` to make it clear to the user. I can work in enabling
support for ANSI mode once this PR is merged as well
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -289,6 +289,16 @@ object CometRegExpReplace extends
CometExpressionSerde[RegExpReplace] {
}
}
+object CometElt extends CometScalarFunction[Elt]("elt") {
+
+ override def getSupportLevel(expr: Elt): SupportLevel = {
+ if (expr.failOnError) {
+ return Unsupported(Some("failOnError=true is not supported"))
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
