ding-young commented on code in PR #16268:
URL: https://github.com/apache/datafusion/pull/16268#discussion_r2151623165
##########
datafusion/common/src/config.rs:
##########
@@ -274,6 +276,60 @@ config_namespace! {
}
}
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum SpillCompression {
+ Zstd,
+ Lz4Frame,
+ Uncompressed,
+}
+
+impl FromStr for SpillCompression {
+ type Err = DataFusionError;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ match s.to_ascii_lowercase().as_str() {
+ "zstd" => Ok(Self::Zstd),
+ "lz4_frame" => Ok(Self::Lz4Frame),
+ "uncompressed" | "" => Ok(Self::Uncompressed),
+ other => Err(DataFusionError::Execution(format!(
+ "Invalid Spill file compression type: {other}. Expected one
of: zstd, lz4, uncompressed"
+ ))),
+ }
+ }
+}
+
+impl ConfigField for SpillCompression {
+ fn visit<V: Visit>(&self, v: &mut V, key: &str, description: &'static str)
{
+ v.some(key, self, description)
+ }
+
+ fn set(&mut self, _: &str, value: &str) -> Result<()> {
+ *self = SpillCompression::from_str(value)?;
+ Ok(())
+ }
+}
+
+impl Display for SpillCompression {
+ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+ let str = match self {
+ Self::Zstd => "zstd",
+ Self::Lz4Frame => "lz4_frame",
+ Self::Uncompressed => "",
Review Comment:
Thanks for the catch. After I made that change, the "default" field in the
docs shows "uncompressed".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
