ding-young commented on code in PR #16268:
URL: https://github.com/apache/datafusion/pull/16268#discussion_r2153447729
##########
datafusion/physical-plan/src/spill/spill_manager.rs:
##########
@@ -44,16 +44,23 @@ pub struct SpillManager {
schema: SchemaRef,
/// Number of batches to buffer in memory during disk reads
batch_read_buffer_capacity: usize,
- // TODO: Add general-purpose compression options
+ /// general-purpose compression options
+ pub(crate) compression: SpillCompression,
}
impl SpillManager {
- pub fn new(env: Arc<RuntimeEnv>, metrics: SpillMetrics, schema: SchemaRef)
-> Self {
+ pub fn new(
+ env: Arc<RuntimeEnv>,
+ metrics: SpillMetrics,
+ schema: SchemaRef,
+ compression: SpillCompression,
Review Comment:
Thanks. This removed some diffs in existing unit tests since the signature
of `new()` remains the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
