2010YOUY01 commented on code in PR #16268:
URL: https://github.com/apache/datafusion/pull/16268#discussion_r2154095345
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -1324,6 +1326,7 @@ impl Stream for SortMergeJoinStream {
impl SortMergeJoinStream {
#[allow(clippy::too_many_arguments)]
pub fn try_new(
+ spill_compression: SpillCompression,
Review Comment:
Nit: For readability, I suggest adding a comment indicating that this
argument is passed through from the configuration xxx.
In the future, we might consider enforcing a naming convention for such
arguments—e.g., always using a `cfg_` prefix like `cfg_spill_compression`.
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -258,6 +259,7 @@ impl ExternalSorter {
batch_size: usize,
sort_spill_reservation_bytes: usize,
sort_in_place_threshold_bytes: usize,
+ spill_compression: SpillCompression,
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
