Re: [PR] feat: Allow cancelling of grouping operations which are CPU bound [datafusion]

[via GitHub]

zhuqi-lucas commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2949615347

   Good result, removed all ignore, corner cases all passed:
   
   ```rust
   running 18 tests
   test 
execution::infinite_cancel::test_infinite_join_agg_cancel::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_agg_cancel::pretend_finite_1_false 
... ok
   test 
execution::infinite_cancel::test_infinite_agg_cancel::pretend_finite_2_true ... 
ok
   test 
execution::infinite_cancel::test_infinite_join_cancel::pretend_finite_1_false 
... ok
   test 
execution::infinite_cancel::test_filter_reject_all_batches_cancel::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_filter_reject_all_batches_cancel::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_join_cancel::pretend_finite_2_true 
... ok
   test 
execution::infinite_cancel::test_infinite_join_agg_cancel::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_hash_join_without_repartition_and_no_agg::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_hash_join_without_repartition_and_no_agg::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_interleave_agg_cancel::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_interleave_cancel::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_interleave_agg_cancel::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_interleave_cancel::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_sort_merge_join_without_repartition_and_no_agg::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_sort_merge_join_without_repartition_and_no_agg::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_sort_cancel::pretend_finite_1_false 
... ok
   test 
execution::infinite_cancel::test_infinite_sort_cancel::pretend_finite_2_true 
... ok
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org