zhuqi-lucas commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2949211366
Thank you @ozankabak @pepijnve I am wandering a easy solution(may be), we just remove final check in the rule, and add yield based leaf nodes, it seems can solve all our problems: 1. The corner will also be resolved since we have yield in leaf nodes. 2. The customers will not be exposed new YieldStreamExec when they don't add leaf node custom exec, because we will add those built-in yieldstream, it will cover all the cases. 3. When customers add custom exec, we also can handle this, it will automatically add YieldStreamExec, this is expected. 4. The performance will not be affected based our previous testing. Any idea? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
