zhuqi-lucas commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2949387541
> > I am wandering a easy solution(may be), we just remove final emissiontype check in the rule, and add yield based leaf nodes, it seems can solve all our problems: > > @zhuqi-lucas I think this is a good idea, let's see where we are at when we unconditionally do this at leaf nodes. This would be easy and quick to do. Then, we can think about the right API to use instead of emission type to arrive at the optimal solution as we collect more tests. Thank you @ozankabak , now i added all 4 reproduce cases which we add ignore for those cases. Let me change the rule to see if we can fix all the corner cases, if so, it's very good to see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
