gabotechs commented on code in PR #16183:
URL: https://github.com/apache/datafusion/pull/16183#discussion_r2126283562
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -102,6 +103,11 @@ async fn run_tests() -> Result<()> {
// to stdout and return OK so they can continue listing other tests.
return Ok(());
}
+ if options.substrait_round_trip && (options.postgres_runner ||
options.complete) {
Review Comment:
Nice! thanks for pointing that out, we've definitely should use that instead
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -102,6 +103,11 @@ async fn run_tests() -> Result<()> {
// to stdout and return OK so they can continue listing other tests.
return Ok(());
}
+ if options.substrait_round_trip && (options.postgres_runner ||
options.complete) {
Review Comment:
Nice! thanks for pointing that out, we definitely should use that instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
