gabotechs opened a new pull request, #16183: URL: https://github.com/apache/datafusion/pull/16183
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> It probably does not fully closes it but it partially addresses: - https://github.com/apache/datafusion/issues/15069 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Being able to execute the full sqllogictest suite adding a Substrait roundtrip. This means: - Parsing the test statement - Building a logical plan out of it - Converting the logical plan to Substrait - Converting the Substrait plan back to logical - Execute it ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Adds a new `DataFusionSubstraitRoundTrip` sqllogictest runner implementation that will do a Substrait roundtrip where it makes sense, and a new `--substrait-round-trip` option to the sqllogictest CLI. Example: Runs the full aggregate.slt file doing a Substrait roundtrip on each individual statement ```shell cargo test --test sqllogictests -- --substrait-round-trip aggregate ``` Runs an individual failing test reproducing one specific issue with the current Substrait conversions ```shell cargo test --test sqllogictests -- --substrait-round-trip aggregate:1522 ``` This is still not enforced in the CI, and I would say the expectations are that it's just another tool to catch existing bugs in the current Substrait conversion code and better communicate them so that contributors have a clear path forward for contributing fixes. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> N/A ## Are there any user-facing changes? No <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
