Copilot commented on code in PR #16182:
URL: https://github.com/apache/datafusion/pull/16182#discussion_r2117256270
##########
benchmarks/compare.py:
##########
@@ -156,8 +173,8 @@ def compare(
console.print(table)
# Calculate averages
- avg_baseline_time = total_baseline_time / len(baseline.queries)
- avg_comparison_time = total_comparison_time / len(comparison.queries)
+ avg_baseline_time = total_baseline_time / (len(baseline.queries) -
failure_count)
+ avg_comparison_time = total_comparison_time / (len(comparison.queries) -
failure_count)
Review Comment:
There is a risk of division by zero if all queries fail; consider adding a
check to ensure the denominator is not zero.
```suggestion
if len(baseline.queries) > failure_count:
avg_baseline_time = total_baseline_time / (len(baseline.queries) -
failure_count)
avg_comparison_time = total_comparison_time /
(len(comparison.queries) - failure_count)
else:
avg_baseline_time = 0.0
avg_comparison_time = 0.0
```
##########
benchmarks/compare.py:
##########
@@ -156,8 +173,8 @@ def compare(
console.print(table)
# Calculate averages
- avg_baseline_time = total_baseline_time / len(baseline.queries)
- avg_comparison_time = total_comparison_time / len(comparison.queries)
+ avg_baseline_time = total_baseline_time / (len(baseline.queries) -
failure_count)
+ avg_comparison_time = total_comparison_time / (len(comparison.queries) -
failure_count)
Review Comment:
There is a risk of division by zero if all queries fail; consider adding a
check to ensure the denominator is not zero.
```suggestion
if len(baseline.queries) - failure_count > 0:
avg_baseline_time = total_baseline_time / (len(baseline.queries) -
failure_count)
else:
avg_baseline_time = 0.0
if len(comparison.queries) - failure_count > 0:
avg_comparison_time = total_comparison_time /
(len(comparison.queries) - failure_count)
else:
avg_comparison_time = 0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
