ding-young commented on code in PR #16182:
URL: https://github.com/apache/datafusion/pull/16182#discussion_r2122839920
##########
benchmarks/src/util/run.rs:
##########
@@ -138,6 +144,28 @@ impl BenchmarkRun {
}
}
+ /// Print the names of failed queries, if any
+ pub fn maybe_print_failures(&self) {
+ let failed_queries: Vec<&str> = self
+ .queries
+ .iter()
+ .filter_map(|q| (!q.success).then_some(q.query.as_str()))
+ .collect();
+
+ if !failed_queries.is_empty() {
+ println!("Failed Queries: {}", failed_queries.join(", "));
+ }
+ }
Review Comment:
Since we call `q.query.as_str` here, expected output may varies in
benchmarks.
For example,
```
// In sort_tpch
Failed Queries: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
// In clickbench
Failed Queries: Query 4, Query 5, Query 7
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
