2010YOUY01 commented on code in PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#discussion_r2122568995
##########
datafusion/physical-expr/src/window/aggregate.rs:
##########
@@ -85,6 +88,18 @@ impl PlainAggregateWindowExpr {
);
}
}
+
+ fn is_window_constant(order_by: &LexOrdering, window_frame: &WindowFrame)
-> bool {
Review Comment:
TIL this convention in point two, I used to think this expr is invalid
```
2. Bound is `CurrentRow` while using `Range` units with no order by clause
```
I suggest to find some SQL specification link for this convention, and add
to the comment. Maybe we should also double check postgres follows this
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
