suibianwanwank commented on code in PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#discussion_r2122842898
##########
datafusion/physical-expr/src/window/aggregate.rs:
##########
@@ -85,6 +88,18 @@ impl PlainAggregateWindowExpr {
);
}
}
+
+ fn is_window_constant(order_by: &LexOrdering, window_frame: &WindowFrame)
-> bool {
Review Comment:
I couldn't find a specific definition of windows in SQL-92, but in postgres,
the following query is valid:
```
SELECT
t0,
SUM(t0) OVER (
RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW
) t1
FROM test;
t0|t1 |
--+---+
10|100|
20|100|
30|100|
40|100|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
