adriangb commented on code in PR #15301:
URL: https://github.com/apache/datafusion/pull/15301#discussion_r2025001379
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -955,7 +939,7 @@ impl TableProvider for ListingTable {
.with_output_ordering(output_ordering)
.with_table_partition_cols(table_partition_cols)
.build(),
- filters.as_ref(),
+ None,
Review Comment:
Because essentially this PR is having to introduce a generalized way to do
filter pushdown instead of the very specific way that ListingTable does it. And
we wouldn't want to do both at the same time. What we want is for ListingTable
to tell us:
- Which filters it can apply just from partitioning (Exact)
- Any other filter becomes `Inexact`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
