adriangb commented on code in PR #15301:
URL: https://github.com/apache/datafusion/pull/15301#discussion_r2022023507
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -433,6 +433,22 @@ impl ExecutionPlan for FilterExec {
}
try_embed_projection(projection, self)
}
+
+ fn push_down_filter(
+ &self,
+ expr: Arc<dyn PhysicalExpr>,
+ ) -> Result<Option<Arc<dyn ExecutionPlan>>> {
+ let mut input = Arc::clone(&self.input);
+ if let Some(new_input) = input.push_down_filter(Arc::clone(&expr))? {
Review Comment:
As per
https://github.com/apache/datafusion/pull/15301#discussion_r2022020818 I gave
this a shot and don't think it's possible.
Influx's approach does downcast matching, which means it won't work for
graphs with custom `ExectuionPlan`s in them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
