alamb commented on code in PR #15301:
URL: https://github.com/apache/datafusion/pull/15301#discussion_r2025374040
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -955,7 +939,7 @@ impl TableProvider for ListingTable {
.with_output_ordering(output_ordering)
.with_table_partition_cols(table_partition_cols)
.build(),
- filters.as_ref(),
+ None,
Review Comment:
I wonder if we can split out the part of this PR that changes how the
filters are pushed down (aka pruning predicate per file rather than one
overall) as a separate PR to isolate the changes into smaller PRs?
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -349,11 +337,13 @@ impl ParquetSource {
}
/// Optional reference to this parquet scan's pruning predicate
+ #[deprecated(note = "ParquetDataSource no longer constructs a
PruningPredicate.")]
pub fn pruning_predicate(&self) -> Option<&Arc<PruningPredicate>> {
self.pruning_predicate.as_ref()
Review Comment:
For anyone following along
- https://github.com/apache/datafusion/issues/15534
##########
datafusion/core/src/datasource/physical_plan/arrow_file.rs:
##########
@@ -201,7 +201,7 @@ impl ExecutionPlan for ArrowExec {
/// Arrow configuration struct that is given to DataSourceExec
/// Does not hold anything special, since [`FileScanConfig`] is sufficient for
arrow
-#[derive(Clone, Default)]
+#[derive(Clone, Default, Debug)]
Review Comment:
Looks good to me -- we can also make a separate PR for it too (not needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
